Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Krystian Hebel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69159 )
Change subject: security/tpm: make tis_probe() return tpm_family ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/104a3535_2a0ee7af PS1, Line 461: *tpm_family = 1;
TPM 2.0 for I2C does exist and it should be detected in the same way as for SPI/LPC. […]
I don't think registers are the same for different interfaces. `TPM_INTF_CAPABILITY` seems to contain `tpmFamily` in case of I2C. And TPM1 had no I2C specification? Look at p. 24 in https://www.trustedcomputinggroup.org/wp-content/uploads/TCG-TPM-I2C-Interfa..., those register addresses are very different from what the driver uses, including how locality is encoded in the address. It seems to use "Infineon I2C Protocol Stack Specification v0.20", which I haven't seen.
-
Sergii Dmytruk (Code Review)