Change in ...coreboot[master]: soc/apl: Add Usb30Mode config option to devicetree

[Felix Singer (Code Review)]

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32048

Change subject: soc/apl: Add Usb30Mode config option to devicetree
......................................................................

soc/apl: Add Usb30Mode config option to devicetree

Change-Id: Id7c241786e01700f7f5e840e10226f748e46d0d8
Signed-off-by: Felix Singer 
---
M src/soc/intel/apollolake/chip.c
M src/soc/intel/apollolake/chip.h
2 files changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/32048/1

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 30a537b..e6ce0b5 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -741,6 +741,8 @@
    /* Disable FSP from locking access to the RTC NVRAM */
    silconfig->RtcLock = 0;

+	silconfig->Usb30Mode = cfg->usb30_mode;
+
    /* Enable Audio clk gate and power gate */
    silconfig->HDAudioClkGate = cfg->hdaudio_clk_gate_enable;
    silconfig->HDAudioPwrGate = cfg->hdaudio_pwr_gate_enable;
diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h
index b9e368c..2cbfaff 100644
--- a/src/soc/intel/apollolake/chip.h
+++ b/src/soc/intel/apollolake/chip.h
@@ -120,6 +120,8 @@
    /* PL2 override value in mW for APL */
    uint16_t tdp_pl2_override_mw;

+	uint8_t usb30_mode;
+
    /* Configure Audio clk gate and power gate
     * IOSF-SB port ID 92 offset 0x530 [5] and [3]
     */

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32048 )

Change subject: soc/apl: Add Usb30Mode config option to devicetree
......................................................................

Patch Set 1:

This change is ready for review.

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32048 )

Change subject: soc/apl: Add Usb30Mode config option to devicetree
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32048/1/src/soc/intel/apollolake/chip.c 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/32048/1/src/soc/intel/apollolake/chip.c@744 
PS1, Line 744: 3
already set by parse_devicetree()

[Felix Singer (Code Review)]

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32048 )

Change subject: soc/apl: Add Usb30Mode config option to devicetree
......................................................................

Abandoned