Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp ......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/f9fcab74_5e3300f3?usp... : PS1, Line 56: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) {
It looks like the configuration for MAX98390 and TAS2563 are the same in coreboot. […]
In the depthcharge stage, we need to use the value of GPIO_RST_SPKR_L.id to distinguish, so we judge separately.
File src/mainboard/google/geralt/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83287/comment/24545eed_13f8740f?usp... : PS1, Line 4: AUDIO_AMP
do we reserve the bits for NAU8318 ?
Because it's not used in the current subproject, no changes have been made.
-
Rui Zhou (Code Review)