Attention is currently required from: Vadim Bendebury, Martin L Roth, Patrick Georgi, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69710 )
Change subject: build: List all Kconfigs in CBFS `config` file, compress it
......................................................................
Patch Set 1:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/69710/comment/fbdf16d2_8e7d90ac
PS1, Line 1231: config-compression := LZMA
I'm just curious: where is this `config-compression` used?
It's quite complicated since it's all written in make script, but basically adding `config` to `cbfs-files-y` tells it to add a CBFS file called `config`, and then it looks if certain `config-xxx` variables are defined to get more details about that file. Some of the code for that starts on lines 350 and 800.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5259ec6f932cdc5780b8843f46dd476da9d19728
Gerrit-Change-Number: 69710
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Attention: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 17 Nov 2022 03:18:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vadim Bendebury
vbendeb@chromium.org
Gerrit-MessageType: comment