EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51288 )
Change subject: mb/google/octopus/var/fleex: Only check LTE sku on fleex ......................................................................
mb/google/octopus/var/fleex: Only check LTE sku on fleex
Fleex has other project share the same FW. Only fleex has LTE sku. So we need to make sure it is fleex then check if LTE sku.
BUG=b:181946744 BRANCH=octopus TEST=Check no SAR table can be loaded with sku id 4 and 5.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I9f3d5fed4315fc716acad1a07735221d154c377e --- M src/mainboard/google/octopus/variants/fleex/variant.c 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/51288/1
diff --git a/src/mainboard/google/octopus/variants/fleex/variant.c b/src/mainboard/google/octopus/variants/fleex/variant.c index 5554fb3..da6910c 100644 --- a/src/mainboard/google/octopus/variants/fleex/variant.c +++ b/src/mainboard/google/octopus/variants/fleex/variant.c @@ -7,6 +7,7 @@ #include <soc/intel/apollolake/chip.h>
#define MIN_LTE_SKU 4 +#define FLEEX_MAX_SKU 20
static bool is_lte_sku(void) { @@ -27,8 +28,10 @@ { const char *filename = NULL;
- if (!is_lte_sku()) - filename = "wifi_sar-fleex.hex"; + /* Only Fleex has LTE sku */ + if (google_chromeec_get_board_sku() <= FLEEX_MAX_SKU) + if (!is_lte_sku()) + filename = "wifi_sar-fleex.hex";
return filename; }