Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74113 )
Change subject: mb/google/myst: Configure WLAN ......................................................................
Patch Set 9:
(4 comments)
File src/mainboard/google/myst/variants/baseboard/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74113/comment/7246e9c0_aaa6450b PS9, Line 5: romstage-y += gpio.c
nit: Move above `ramstage` to match previous boards.
This was done intentionally to make the variable assignment alphabetical. Let me know if you have a strong preference.
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74113/comment/743a184d_eb507af3 PS9, Line 193: static const struct soc_amd_gpio early_gpio_table[] = {
Where did these GPIO values come from?
go/myst-gpios
https://review.coreboot.org/c/coreboot/+/74113/comment/01b44400_bc2f8a9d PS9, Line 202: pcie_gpio_table
Skyrim defines this as `romstage_gpio_table`, which is used in `baseboard_romstage_gpio_table()`. […]
This is how it was named originally on Skyrim. It was changed by AMD, I can apply the same change.
https://review.coreboot.org/c/coreboot/+/74113/comment/be44cce1_eddc089f PS9, Line 228: __weak void variant_pcie_gpio_table(const struct soc_amd_gpio **gpio, size_t *size)
This isn't defined for any other board. It's also not called anywhere. […]
It's called in mb_pre_fspm in romstage.c in this board. We can align naming with other boards
-
Jon Murphy (Code Review)