Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42984 )
Change subject: include/cpu/x86/lapic: Add support for x86_64 ......................................................................
include/cpu/x86/lapic: Add support for x86_64
Fix integer with different size to pointer conversion.
Change-Id: I9c13892b2d79be12cc6bf7bc0a5e3a39b64032a1 Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/include/cpu/x86/lapic.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/42984/1
diff --git a/src/include/cpu/x86/lapic.h b/src/include/cpu/x86/lapic.h index 28978f2..5ab5755 100644 --- a/src/include/cpu/x86/lapic.h +++ b/src/include/cpu/x86/lapic.h @@ -9,12 +9,12 @@
static __always_inline uint32_t lapic_read(unsigned int reg) { - return read32((volatile void *)(LAPIC_DEFAULT_BASE + reg)); + return read32((volatile void *)(uintptr_t)(LAPIC_DEFAULT_BASE + reg)); }
static __always_inline void lapic_write(unsigned int reg, uint32_t v) { - write32((volatile void *)(LAPIC_DEFAULT_BASE + reg), v); + write32((volatile void *)(uintptr_t)(LAPIC_DEFAULT_BASE + reg), v); }
static __always_inline void lapic_wait_icr_idle(void)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42984 )
Change subject: include/cpu/x86/lapic: Add support for x86_64 ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42984
to look at the new patch set (#2).
Change subject: include/cpu/x86/lapic: Add support for x86_64 ......................................................................
include/cpu/x86/lapic: Add support for x86_64
Fix integer with different size to pointer conversion.
Change-Id: I9c13892b2d79be12cc6bf7bc0a5e3a39b64032a1 Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/include/cpu/x86/lapic.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/42984/2
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42984 )
Change subject: include/cpu/x86/lapic: Add support for x86_64 ......................................................................
include/cpu/x86/lapic: Add support for x86_64
Fix integer with different size to pointer conversion.
Change-Id: I9c13892b2d79be12cc6bf7bc0a5e3a39b64032a1 Signed-off-by: Patrick Rudolph siro@das-labor.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/42984 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/cpu/x86/lapic.h 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/include/cpu/x86/lapic.h b/src/include/cpu/x86/lapic.h index 28978f2..5ab5755 100644 --- a/src/include/cpu/x86/lapic.h +++ b/src/include/cpu/x86/lapic.h @@ -9,12 +9,12 @@
static __always_inline uint32_t lapic_read(unsigned int reg) { - return read32((volatile void *)(LAPIC_DEFAULT_BASE + reg)); + return read32((volatile void *)(uintptr_t)(LAPIC_DEFAULT_BASE + reg)); }
static __always_inline void lapic_write(unsigned int reg, uint32_t v) { - write32((volatile void *)(LAPIC_DEFAULT_BASE + reg), v); + write32((volatile void *)(uintptr_t)(LAPIC_DEFAULT_BASE + reg), v); }
static __always_inline void lapic_wait_icr_idle(void)
-
Angel Pons (Code Review) -
Patrick Rudolph (Code Review)