Attention is currently required from: Nico Huber, Michał Żygowski, Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52935 )
Change subject: nb/amd/agesa/family14/northbridge.c: Report missing resources ......................................................................
Patch Set 2:
(6 comments)
Patchset:
PS2: a
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/52935/comment/c9ff2939_44031a4d PS2, Line 285: Ff typo? If
https://review.coreboot.org/c/coreboot/+/52935/comment/73c2d05f_5b5c62f9 PS2, Line 288: __f4_dev These fX dev pointers are signs that the code could use more PCI drivers
https://review.coreboot.org/c/coreboot/+/52935/comment/a90f937d_98b25f3c PS2, Line 289: resource_t unsigned long
https://review.coreboot.org/c/coreboot/+/52935/comment/b415d636_ee341232 PS2, Line 382: resource_t unsigned long
https://review.coreboot.org/c/coreboot/+/52935/comment/2c377c29_89b06a4f PS2, Line 382: // 4 1T What does this comment mean?