Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Kun Liu.
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 )
Change subject: mb/google/rex: Initial setup for gpio config
......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/google/rex/variants/screebo/gpio.c:
https://review.coreboot.org/c/coreboot/+/74475/comment/967b8da8_a0518a37
PS3, Line 153:
nit: tab
https://review.coreboot.org/c/coreboot/+/74475/comment/bc28510e_4a808f29
PS3, Line 205:
ditto
https://review.coreboot.org/c/coreboot/+/74475/comment/dbeb1259_c0e32493
PS3, Line 247:
ditto
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74475
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7
Gerrit-Change-Number: 74475
Gerrit-PatchSet: 3
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Zhou
zhouguohui@huaqin.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 17 Apr 2023 16:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment