Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/29107
Change subject: mb/lenovo/*/romstage: Remove explicit power-on defaults ......................................................................
mb/lenovo/*/romstage: Remove explicit power-on defaults
Change-Id: Ib359e4039f87bb87faac040f24f70cc0988c0ea8 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/l520/romstage.c M src/mainboard/lenovo/t420/romstage.c M src/mainboard/lenovo/t420s/romstage.c M src/mainboard/lenovo/t430s/romstage.c M src/mainboard/lenovo/t520/romstage.c M src/mainboard/lenovo/t530/romstage.c M src/mainboard/lenovo/x220/romstage.c M src/mainboard/lenovo/x230/romstage.c 8 files changed, 1 insertion(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/29107/1
diff --git a/src/mainboard/lenovo/l520/romstage.c b/src/mainboard/lenovo/l520/romstage.c index 0f6ffed..61319f5 100644 --- a/src/mainboard/lenovo/l520/romstage.c +++ b/src/mainboard/lenovo/l520/romstage.c @@ -34,8 +34,8 @@
void mainboard_rcba_config(void) { - RCBA32(0x3414) = 0x00000000; } + const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 0, -1 }, { 1, 0, -1 }, diff --git a/src/mainboard/lenovo/t420/romstage.c b/src/mainboard/lenovo/t420/romstage.c index bef2562..aad8348 100644 --- a/src/mainboard/lenovo/t420/romstage.c +++ b/src/mainboard/lenovo/t420/romstage.c @@ -65,7 +65,6 @@
void mainboard_rcba_config(void) { - RCBA32(BUC) = 0; }
// OC3 set in bios to port 2-7, OC7 set in bios to port 10-13 diff --git a/src/mainboard/lenovo/t420s/romstage.c b/src/mainboard/lenovo/t420s/romstage.c index be8052c..8004e2f 100644 --- a/src/mainboard/lenovo/t420s/romstage.c +++ b/src/mainboard/lenovo/t420s/romstage.c @@ -67,7 +67,6 @@
void mainboard_rcba_config(void) { - RCBA32(BUC) = 0; }
const struct southbridge_usb_port mainboard_usb_ports[] = { diff --git a/src/mainboard/lenovo/t430s/romstage.c b/src/mainboard/lenovo/t430s/romstage.c index 633ba3f..b409b5e 100644 --- a/src/mainboard/lenovo/t430s/romstage.c +++ b/src/mainboard/lenovo/t430s/romstage.c @@ -40,7 +40,6 @@
void mainboard_rcba_config(void) { - RCBA32(BUC) = 0; }
const struct southbridge_usb_port mainboard_usb_ports[] = { diff --git a/src/mainboard/lenovo/t520/romstage.c b/src/mainboard/lenovo/t520/romstage.c index 4fcd651..cdd0d45 100644 --- a/src/mainboard/lenovo/t520/romstage.c +++ b/src/mainboard/lenovo/t520/romstage.c @@ -77,7 +77,6 @@
void mainboard_rcba_config(void) { - RCBA32(BUC) = 0; }
const struct southbridge_usb_port mainboard_usb_ports[] = { diff --git a/src/mainboard/lenovo/t530/romstage.c b/src/mainboard/lenovo/t530/romstage.c index 88e07c1..68dd694 100644 --- a/src/mainboard/lenovo/t530/romstage.c +++ b/src/mainboard/lenovo/t530/romstage.c @@ -69,7 +69,6 @@
void mainboard_rcba_config(void) { - RCBA32(BUC) = 0; }
void mainboard_early_init(int s3resume) diff --git a/src/mainboard/lenovo/x220/romstage.c b/src/mainboard/lenovo/x220/romstage.c index 96e0284..6efcd01 100644 --- a/src/mainboard/lenovo/x220/romstage.c +++ b/src/mainboard/lenovo/x220/romstage.c @@ -50,7 +50,6 @@
void mainboard_rcba_config(void) { - RCBA32(BUC) = 0; }
void mainboard_fill_pei_data(struct pei_data *pei_data) diff --git a/src/mainboard/lenovo/x230/romstage.c b/src/mainboard/lenovo/x230/romstage.c index 1ddaedf..94bcab3 100644 --- a/src/mainboard/lenovo/x230/romstage.c +++ b/src/mainboard/lenovo/x230/romstage.c @@ -48,7 +48,6 @@
void mainboard_rcba_config(void) { - RCBA32(BUC) = 0; }
const struct southbridge_usb_port mainboard_usb_ports[] = {