Attention is currently required from: Nico Huber, Furquan Shaikh.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49407 )
Change subject: soc/intel/common/gpio: Add gpio_routes_ioapic_irq function
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/49407/comment/ff6759d8_695080ed
PS7, Line 653: gpio_routes_ioapic_irq
I think it would be perfectly legal to program a GPIO for IOAPIC in romstage (perhaps uncommon), b […]
All excellent points, always one step ahead of me 😉 Let me time this, if it's not too bad, I'd rather stick with this as the shared state is only in one place (the HW register) 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49407
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iceda89cb111caa15056c204b143b4a17d59e523e
Gerrit-Change-Number: 49407
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 25 Feb 2021 21:59:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment