Attention is currently required from: Lance Zhao, Tarun Tuli, Kapil Porwal, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70063 )
Change subject: acpi: Helper functions to add certain _DSD properties
......................................................................
Patch Set 8:
(1 comment)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/70063/comment/8a5c8d8e_9cbeb28a
PS8, Line 1209: acpi_device_add_integer_property_with_uuid
do u see anyone calling into this func directly ? if not then consider to make it static ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70063
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bb432dd4e8f320d2c0d7f378dc2d7b3a770b541
Gerrit-Change-Number: 70063
Gerrit-PatchSet: 8
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 19:19:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment