Attention is currently required from: Hung-Te Lin, Martin Roth, Rex-BC Chen, Yidi Lin, JG Poxu.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52598 )
Change subject: soc/mediatek/mt8195: Add GPIO driver
......................................................................
Patch Set 4:
(3 comments)
File src/soc/mediatek/mt8195/gpio.c:
https://review.coreboot.org/c/coreboot/+/52598/comment/fc9b3596_64249855
PS4, Line 5: #include <assert.h>
Do we need this?
https://review.coreboot.org/c/coreboot/+/52598/comment/2e5a89b4_597241bc
PS4, Line 54: )
Add {} for if clause
File src/soc/mediatek/mt8195/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/52598/comment/f54cdb94_889001ed
PS4, Line 42: TP_GPIO0_AO
Please align with "0"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica1b1c80a851075599442298bb6675caf5c72f57
Gerrit-Change-Number: 52598
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: JG Poxu
jg_poxu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Attention: JG Poxu
jg_poxu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 08:51:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment