Change in coreboot[master]: [WIP,RFC] soc/amd/common: Move sb_reset_i2c_slaves() - coreboot-gerrit

21 Dec 2020


      Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42689 )
Change subject: [WIP,RFC] soc/amd/common: Move sb_reset_i2c_slaves()
......................................................................
Patch Set 8:
i don't think that this should be moved to the common gpio code, since it's mostly about i2c. there will also be some gpio-related changes for the i2c pins in renoir/cezanne. moving the code in its current state to the common designware i2c code is probably not the way to go, since the gpio part is very soc-specific. the code apart from the gpio control and set should be quite generic though
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/42689
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e761236fc0602babb9a96956b143ecd0d2c61de
Gerrit-Change-Number: 42689
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Dec 2020 20:43:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment