Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48604 )
Change subject: Doc/mb/lenovo: Explain simpler GM45 flash method first ......................................................................
Doc/mb/lenovo: Explain simpler GM45 flash method first
Do not mislead newcomers into thinking the GM45 series laptops are hard to flash. Describe the simple coreboot flashing procedure first, then explain how to remove the ME firmware and use a custom flash layout.
Also, reword a sentence on the simple flashing procedure for clarity.
Change-Id: Ie83ec3d20f00e9d9c869e483e24d601506857f07 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/mainboard/lenovo/montevina_series.md 1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/48604/1
diff --git a/Documentation/mainboard/lenovo/montevina_series.md b/Documentation/mainboard/lenovo/montevina_series.md index c886a21..b513c97 100644 --- a/Documentation/mainboard/lenovo/montevina_series.md +++ b/Documentation/mainboard/lenovo/montevina_series.md @@ -9,6 +9,15 @@ Note that this does not allow you to determine whether the chip is in a SOIC-8 or a SOIC-16 package.
+## Installing with ME firmware + +To install coreboot and keep ME working, you don't need to do anything special +with the flash descriptor. Only flash the `bios` region externally and don't +touch any other regions: +```console +# flashrom -p YOUR_PROGRAMMER -w coreboot.rom --ifd -i bios +``` + ## Installing without ME firmware
```eval_rst @@ -127,15 +136,6 @@
Then build coreboot and flash whole `build/coreboot.rom` to the chip.
-## Installing with ME firmware - -To install coreboot and keep ME working, you don't need to do anything special -with the flash descriptor. Just flash only `bios` externally and don't touch any -other regions: -```console -# flashrom -p YOUR_PROGRAMMER -w coreboot.rom --ifd -i bios -``` - ## Flash layout
The flash layouts of the OEM firmware are as follows:
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48604 )
Change subject: Doc/mb/lenovo: Explain simpler GM45 flash method first ......................................................................
Patch Set 1: Code-Review+2
Swift Geek (Sebastian Grzywna) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48604 )
Change subject: Doc/mb/lenovo: Explain simpler GM45 flash method first ......................................................................
Patch Set 1: Code-Review+2
Tested on 7XET72WW (X200 4MiB flash) vendor image as starting point, and as expected only bios region from the flash is modified (compared with ifdtool -x before/after)
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48604 )
Change subject: Doc/mb/lenovo: Explain simpler GM45 flash method first ......................................................................
Patch Set 1: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48604 )
Change subject: Doc/mb/lenovo: Explain simpler GM45 flash method first ......................................................................
Doc/mb/lenovo: Explain simpler GM45 flash method first
Do not mislead newcomers into thinking the GM45 series laptops are hard to flash. Describe the simple coreboot flashing procedure first, then explain how to remove the ME firmware and use a custom flash layout.
Also, reword a sentence on the simple flashing procedure for clarity.
Change-Id: Ie83ec3d20f00e9d9c869e483e24d601506857f07 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48604 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Swift Geek (Sebastian Grzywna) swiftgeek@gmail.com Reviewed-by: Evgeny Zinoviev me@ch1p.io --- M Documentation/mainboard/lenovo/montevina_series.md 1 file changed, 9 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Swift Geek (Sebastian Grzywna): Looks good to me, approved Evgeny Zinoviev: Looks good to me, approved
diff --git a/Documentation/mainboard/lenovo/montevina_series.md b/Documentation/mainboard/lenovo/montevina_series.md index c886a21..b513c97 100644 --- a/Documentation/mainboard/lenovo/montevina_series.md +++ b/Documentation/mainboard/lenovo/montevina_series.md @@ -9,6 +9,15 @@ Note that this does not allow you to determine whether the chip is in a SOIC-8 or a SOIC-16 package.
+## Installing with ME firmware + +To install coreboot and keep ME working, you don't need to do anything special +with the flash descriptor. Only flash the `bios` region externally and don't +touch any other regions: +```console +# flashrom -p YOUR_PROGRAMMER -w coreboot.rom --ifd -i bios +``` + ## Installing without ME firmware
```eval_rst @@ -127,15 +136,6 @@
Then build coreboot and flash whole `build/coreboot.rom` to the chip.
-## Installing with ME firmware - -To install coreboot and keep ME working, you don't need to do anything special -with the flash descriptor. Just flash only `bios` externally and don't touch any -other regions: -```console -# flashrom -p YOUR_PROGRAMMER -w coreboot.rom --ifd -i bios -``` - ## Flash layout
The flash layouts of the OEM firmware are as follows:
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Evgeny Zinoviev (Code Review)
-
Hung-Te Lin (Code Review)
-
Swift Geek (Sebastian Grzywna) (Code Review)