Attention is currently required from: Arthur Heymans, Angel Pons, Felix Held.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53991 )
Change subject: cpu/amd/agesa/family15tn/model_15_init.c: create correct MTRR solution
......................................................................
Patch Set 3:
(1 comment)
File src/cpu/amd/agesa/family15tn/model_15_init.c:
https://review.coreboot.org/c/coreboot/+/53991/comment/b6b1ecae_9b2435eb
PS3, Line 39: execution
Yes, I probably meant AGESA, because I recall having a longer execution time of AmdInitLate. […]
I have no fam15tn platform to test so can't say. It definitely helps on fam16 binaryPI where the AGESA had to be accessed one more time before payload for AmdInitLate. Replicated the setup here as well in case one includes a larger payload than SeaBIOS. E.g. EDK2 UEFI payload depending on included features may have 700KB or more. In such case the speedup would be noticable I think.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53991
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3efcd4bb62953cae378e725d10a4b7e240dd4251
Gerrit-Change-Number: 53991
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 09 Dec 2021 14:07:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur.heymans@9elements.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment