Attention is currently required from: Martin Roth.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50240 )
Change subject: soc/amd/picasso: add UPD for USB3 phy setting adjust
......................................................................
Patch Set 7:
(1 comment)
File src/soc/amd/picasso/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/50240/comment/ed6e1cf6_46ae0d7d
PS4, Line 131: memcpy(&scfg->usb_3_port0_phy_tune, &cfg->usb3_phy_tune_params[0],
: sizeof(scfg->usb_3_port0_phy_tune[0]));
Right, I'm just wondering if the enable should be more. […]
yes, The default value was given in both trembyle and dalboz devtree. and the value is refer to the AGESA. Also remove the if condition and let UPD use the default setting if no variant wants to override it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50240
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d5f69e840952cc5171af1ce8597628d1bede5cb
Gerrit-Change-Number: 50240
Gerrit-PatchSet: 7
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 19:15:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: chris wang
Chris.Wang@amd.com
Gerrit-MessageType: comment