Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons.
Utkarsh Verma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74128 )
Change subject: arch/x86/smbios: Refactor snprintf() uses
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74128/comment/8638c04f_ff6f30d9
PS7, Line 7: arch/x86/smbios: Avoid buffer overflows
"buffer overflow" usually refers to writing beyond the bounds of a buffer. […]
Done
https://review.coreboot.org/c/coreboot/+/74128/comment/d7b6903a_a76f1628
PS7, Line 11: static analysers.
This commit also alters buffer sizes, please mention that as well.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74128
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbf93fd113791b6faa1e5128da8e692f7f00ac73
Gerrit-Change-Number: 74128
Gerrit-PatchSet: 8
Gerrit-Owner: Utkarsh Verma
utkarsh@bitbanged.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 02:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment