Attention is currently required from: Martin L Roth, Paul Menzel.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75475?usp=email )
Change subject: soc/intel/common/crashlog: Add support for IOE die
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75475/comment/7298e452_c148a158 :
PS4, Line 7: IOE die
What is IOE?
I/O Expander
File src/soc/intel/common/block/include/intelblocks/crashlog.h:
https://review.coreboot.org/c/coreboot/+/75475/comment/b632cdd1_3f568af2 :
PS4, Line 35: :16
Why is this a bitfield?
Just for consistency with other code. removing or keeping it won't matter technically.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75475?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id90cf0095258c4f7003e4c5f2564bb763e687b75
Gerrit-Change-Number: 75475
Gerrit-PatchSet: 5
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 05 Jun 2023 22:58:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment