Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35004 )
Change subject: x86: Introduce RESET_VECTOR_IN_RAM option
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35004/10/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/35004/10/src/Kconfig@155
PS10, Line 155: config RESET_VECTOR_IN_RAM
Can't this go in src/arch/x86/Kconfig?
https://review.coreboot.org/c/coreboot/+/35004/10/src/arch/x86/memlayout.ld
File src/arch/x86/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/35004/10/src/arch/x86/memlayout.ld@...
PS10, Line 20: #if ENV_ROMSTAGE_OR_BEFORE
Why not &&?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I098ecf8bf200550db1e15f178f7661c1ac516dc5
Gerrit-Change-Number: 35004
Gerrit-PatchSet: 10
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:37:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment