Attention is currently required from: Sean Rhodes.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72800 )
Change subject: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT
......................................................................
Patch Set 8:
(1 comment)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/72800/comment/9688802e_e9f538f6
PS4, Line 1004: Don't support D3Cold"
: default n if NO_S0IX_SUPPORT
Sheng, while I usually would agree fixing stuff instead of reverting, there are IMHO two strong argu […]
Michael,
1. Relevant reviewers have been added to the patch series and ample of time have been allowed for everyone to review this, hence their proper review process has been followed, please correct me if I am wrong.
2. It still does not justify a blanket revert, and in the past there were always miss like this, I would prefer to follow the same process to communicate with the patch submitter and come up with a proper fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I718952165daa6471f11e8025e745fe7c249d3b46
Gerrit-Change-Number: 72800
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Fri, 07 Apr 2023 19:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: comment