Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82644?usp=email )
Change subject: acpi/acpi_apic: use generic MADT IRQ override function for SCI override ......................................................................
acpi/acpi_apic: use generic MADT IRQ override function for SCI override
Call acpi_create_madt_irqoverride from acpi_create_madt_sci_override with the correct parameters instead or re-implementing the same functionality.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I7e6ee0eed837c2d46da62092b7cc5669dc177d8d --- M src/acpi/acpi_apic.c 1 file changed, 1 insertion(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/82644/1
diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c index 4b5b0fe..45d642a 100644 --- a/src/acpi/acpi_apic.c +++ b/src/acpi/acpi_apic.c @@ -132,14 +132,7 @@ if (CONFIG(ACPI_NO_PCAT_8259)) irq = gsi;
- irqoverride->type = IRQ_SOURCE_OVERRIDE; /* Interrupt source override */ - irqoverride->length = sizeof(acpi_madt_irqoverride_t); - irqoverride->bus = MP_BUS_ISA; - irqoverride->source = irq; - irqoverride->gsirq = gsi; - irqoverride->flags = flags; - - return irqoverride->length; + return acpi_create_madt_irqoverride(irqoverride, MP_BUS_ISA, irq, gsi, flags); }
static unsigned long acpi_create_madt_ioapic_gsi0_default(unsigned long current)