Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74123 )
Change subject: mb/amd/birman/port_descriptors: split files for phoenix/glinda ......................................................................
mb/amd/birman/port_descriptors: split files for phoenix/glinda
Glinda and Phoenix have different requirements, so split the birman port_descriptors file to betty apply to each SoC.
Signed-off-by: Fred Reitberger reitbergerfred@gmail.com Change-Id: Ia28cf4172b6adada10809e0135b2459077fa3da0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74123 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/birman/Makefile.inc R src/mainboard/amd/birman/port_descriptors_glinda.c C src/mainboard/amd/birman/port_descriptors_phoenix.c 3 files changed, 20 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/amd/birman/Makefile.inc b/src/mainboard/amd/birman/Makefile.inc index df931d9..079e72b 100644 --- a/src/mainboard/amd/birman/Makefile.inc +++ b/src/mainboard/amd/birman/Makefile.inc @@ -4,11 +4,13 @@ bootblock-y += early_gpio.c bootblock-y += ec.c
-romstage-y += port_descriptors.c +romstage-$(CONFIG_BOARD_AMD_BIRMAN_PHOENIX) += port_descriptors_phoenix.c +romstage-$(CONFIG_BOARD_AMD_BIRMAN_GLINDA) += port_descriptors_glinda.c
ramstage-y += chromeos.c ramstage-y += gpio.c -ramstage-y += port_descriptors.c +ramstage-$(CONFIG_BOARD_AMD_BIRMAN_PHOENIX) += port_descriptors_phoenix.c +ramstage-$(CONFIG_BOARD_AMD_BIRMAN_GLINDA) += port_descriptors_glinda.c
ifneq ($(wildcard $(MAINBOARD_BLOBS_DIR)/APCB_FP8_LPDDR5.bin),) APCB_SOURCES = $(MAINBOARD_BLOBS_DIR)/APCB_FP8_LPDDR5.bin diff --git a/src/mainboard/amd/birman/port_descriptors.c b/src/mainboard/amd/birman/port_descriptors_glinda.c similarity index 100% rename from src/mainboard/amd/birman/port_descriptors.c rename to src/mainboard/amd/birman/port_descriptors_glinda.c diff --git a/src/mainboard/amd/birman/port_descriptors.c b/src/mainboard/amd/birman/port_descriptors_phoenix.c similarity index 100% copy from src/mainboard/amd/birman/port_descriptors.c copy to src/mainboard/amd/birman/port_descriptors_phoenix.c