Change in ...coreboot[master]: drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )
Change subject: drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs ......................................................................
Patch Set 52:
(4 comments)
https://review.coreboot.org/#/c/25634/52/src/drivers/intel/fsp2_0/Kconfig File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/#/c/25634/52/src/drivers/intel/fsp2_0/Kconfig@17... PS52, Line 175: config FSP_USES_MP_SERVICES_PPI Create a generalized way to include the PPI interface. Not for every single feature. e.g. FSP_PEIM_TO_PEIM_INTERFACE
https://review.coreboot.org/#/c/25634/52/src/drivers/intel/fsp2_0/Makefile.i... File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/#/c/25634/52/src/drivers/intel/fsp2_0/Makefile.i... PS52, Line 41: ramstage-$(CONFIG_FSP_USES_MP_SERVICES_PPI) += ppi/fsp_mp_service_ppi.c same here subdirs-$(CONFIG_FSP_PEIM_TO_PEIM_INTERFACE) += ppi and it's own makefile in the PPI directory
https://review.coreboot.org/#/c/25634/52/src/drivers/intel/fsp2_0/include/fs... File src/drivers/intel/fsp2_0/include/fsp/fsp_mp_service_ppi.h:
PS52: If we start here with a PPI (interface) also make it part of the include/fsp/ppi/mp_service.h
https://review.coreboot.org/#/c/25634/52/src/drivers/intel/fsp2_0/ppi/fsp_mp... File src/drivers/intel/fsp2_0/ppi/fsp_mp_service_ppi.c:
PS52: rename to mp_service.c
-
Philipp Deppenwiese (Code Review)