Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81468?usp=email )
Change subject: mb/google/dedede: Remove blank lines before '}' and after '{' ......................................................................
mb/google/dedede: Remove blank lines before '}' and after '{'
Change-Id: I3c7b28acfb4da62e1cab784d41a4a3b09cbb4972 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/mainboard/google/dedede/mainboard.c M src/mainboard/google/dedede/variants/baseboard/memory.c M src/mainboard/google/dedede/variants/beadrix/memory.c M src/mainboard/google/dedede/variants/drawcia/gpio.c M src/mainboard/google/dedede/variants/drawcia/variant.c M src/mainboard/google/dedede/variants/galtic/gpio.c M src/mainboard/google/dedede/variants/pirika/gpio.c 7 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81468/1
diff --git a/src/mainboard/google/dedede/mainboard.c b/src/mainboard/google/dedede/mainboard.c index b381d98..aae4155 100644 --- a/src/mainboard/google/dedede/mainboard.c +++ b/src/mainboard/google/dedede/mainboard.c @@ -128,18 +128,15 @@
static void mainboard_fill_ssdt(const struct device *dev) { - acpigen_write_scope("\_SB"); acpigen_write_method_serialized("MS0X", 1); mainboard_generate_s0ix_hook(); acpigen_write_method_end(); /* Method */ acpigen_write_scope_end(); /* Scope */ - }
void __weak variant_generate_s0ix_hook(enum s0ix_entry entry) { - /* Add board-specific MS0X entries */ /* if (s0ix_entry == S0IX_ENTRY) { diff --git a/src/mainboard/google/dedede/variants/baseboard/memory.c b/src/mainboard/google/dedede/variants/baseboard/memory.c index aa52636..da8439a 100644 --- a/src/mainboard/google/dedede/variants/baseboard/memory.c +++ b/src/mainboard/google/dedede/variants/baseboard/memory.c @@ -7,7 +7,6 @@ #include <soc/romstage.h>
static const struct mb_cfg baseboard_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, diff --git a/src/mainboard/google/dedede/variants/beadrix/memory.c b/src/mainboard/google/dedede/variants/beadrix/memory.c index bfef45b..d80832d 100644 --- a/src/mainboard/google/dedede/variants/beadrix/memory.c +++ b/src/mainboard/google/dedede/variants/beadrix/memory.c @@ -7,7 +7,6 @@ #include <soc/romstage.h>
static const struct mb_cfg board_memcfg_cfg = { - .dq_map[DDR_CH0] = { {0xf, 0xf0}, {0xf, 0xf0}, diff --git a/src/mainboard/google/dedede/variants/drawcia/gpio.c b/src/mainboard/google/dedede/variants/drawcia/gpio.c index fa4d4d5..d42b38e 100644 --- a/src/mainboard/google/dedede/variants/drawcia/gpio.c +++ b/src/mainboard/google/dedede/variants/drawcia/gpio.c @@ -9,14 +9,12 @@
/* Pad configuration in ramstage */ static const struct pad_config not_board6or8_gpio_table[] = { - /* C12 : AP_PEN_DET_ODL */ PAD_CFG_GPI_GPIO_DRIVER(GPP_C12, UP_20K, DEEP), };
/* bid6: Pad configuration for board version 6 or 8 in ramstage */ static const struct pad_config board6or8_gpio_table[] = { - /* A10 : WWAN_EN */ PAD_CFG_GPO(GPP_A10, 1, PWROK),
diff --git a/src/mainboard/google/dedede/variants/drawcia/variant.c b/src/mainboard/google/dedede/variants/drawcia/variant.c index 9077bae..5f85f6a 100644 --- a/src/mainboard/google/dedede/variants/drawcia/variant.c +++ b/src/mainboard/google/dedede/variants/drawcia/variant.c @@ -19,7 +19,6 @@ uint32_t sku_id = google_chromeec_get_board_sku();
if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED))) { - if (sku_id >= OSCINO_SKU_START && sku_id <= OSCINO_SKU_END) return "wifi_sar-oscino.hex"; else diff --git a/src/mainboard/google/dedede/variants/galtic/gpio.c b/src/mainboard/google/dedede/variants/galtic/gpio.c index e2e6669..d92bdf5 100644 --- a/src/mainboard/google/dedede/variants/galtic/gpio.c +++ b/src/mainboard/google/dedede/variants/galtic/gpio.c @@ -5,7 +5,6 @@
/* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { - /* A11 : TOUCH_RPT_EN */ PAD_NC(GPP_A11, NONE),
diff --git a/src/mainboard/google/dedede/variants/pirika/gpio.c b/src/mainboard/google/dedede/variants/pirika/gpio.c index e2e6669..d92bdf5 100644 --- a/src/mainboard/google/dedede/variants/pirika/gpio.c +++ b/src/mainboard/google/dedede/variants/pirika/gpio.c @@ -5,7 +5,6 @@
/* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { - /* A11 : TOUCH_RPT_EN */ PAD_NC(GPP_A11, NONE),