Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33026
Change subject: google/rambi: set default VBIOS PCI ID ......................................................................
google/rambi: set default VBIOS PCI ID
All rambi variants have the same GPU PCI ID, so set it here to avoid having to set it in each board's config.
Change-Id: Id1e0580b55e3590d868cb839987f06c49bb07cf5 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/rambi/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/33026/1
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index 6d0c0df..cc0dfd7 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -90,6 +90,11 @@ string default ""
+config VGA_BIOS_ID + string + depends on VGA_BIOS + default "8086,0f31" + config VGA_BIOS_FILE string default "pci8086,0f31.rom"
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33026 )
Change subject: google/rambi: set default VBIOS PCI ID ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33026/1/src/mainboard/google/rambi/Kconfig File src/mainboard/google/rambi/Kconfig:
https://review.coreboot.org/#/c/33026/1/src/mainboard/google/rambi/Kconfig@9... PS1, Line 96: default "8086,0f31" That's the only ID in soc/intel/baytrail. Move it there?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33026
to look at the new patch set (#2).
Change subject: soc/intel/baytrail: set default VBIOS filename and PCI ID ......................................................................
soc/intel/baytrail: set default VBIOS filename and PCI ID
All Baytrail boards have the same GPU PCI ID, so set it here to avoid having to set it in each board's config.
Move the VGA_BIOS_FILE config from google/rambi into soc/baytrail since it likewise applies to all Baytrail boards.
Change-Id: Id1e0580b55e3590d868cb839987f06c49bb07cf5 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/rambi/Kconfig M src/soc/intel/baytrail/Kconfig 2 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/33026/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33026 )
Change subject: soc/intel/baytrail: set default VBIOS filename and PCI ID ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33026/1/src/mainboard/google/rambi/Kconfig File src/mainboard/google/rambi/Kconfig:
https://review.coreboot.org/#/c/33026/1/src/mainboard/google/rambi/Kconfig@9... PS1, Line 96: default "8086,0f31"
That's the only ID in soc/intel/baytrail. […]
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33026 )
Change subject: soc/intel/baytrail: set default VBIOS filename and PCI ID ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33026
to look at the new patch set (#3).
Change subject: soc/intel/baytrail: set default VBIOS filename and PCI ID ......................................................................
soc/intel/baytrail: set default VBIOS filename and PCI ID
All Baytrail boards have the same GPU PCI ID, so set it here to avoid having to set it in each board's config.
Move the VGA_BIOS_FILE config from google/rambi into soc/baytrail since it likewise applies to all Baytrail boards.
Change-Id: Id1e0580b55e3590d868cb839987f06c49bb07cf5 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/rambi/Kconfig M src/soc/intel/baytrail/Kconfig 2 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/33026/3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33026 )
Change subject: soc/intel/baytrail: set default VBIOS filename and PCI ID ......................................................................
Patch Set 3: Code-Review+2
Matt DeVillier has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33026 )
Change subject: soc/intel/baytrail: set default VBIOS filename and PCI ID ......................................................................
soc/intel/baytrail: set default VBIOS filename and PCI ID
All Baytrail boards have the same GPU PCI ID, so set it here to avoid having to set it in each board's config.
Move the VGA_BIOS_FILE config from google/rambi into soc/baytrail since it likewise applies to all Baytrail boards.
Change-Id: Id1e0580b55e3590d868cb839987f06c49bb07cf5 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33026 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/rambi/Kconfig M src/soc/intel/baytrail/Kconfig 2 files changed, 10 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index c47b3d7..56d44bc 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -90,10 +90,6 @@ string default ""
-config VGA_BIOS_FILE - string - default "pci8086,0f31.rom" - config MAINBOARD_SMBIOS_MANUFACTURER string default "GOOGLE" diff --git a/src/soc/intel/baytrail/Kconfig b/src/soc/intel/baytrail/Kconfig index 03ad31d..43c2906 100644 --- a/src/soc/intel/baytrail/Kconfig +++ b/src/soc/intel/baytrail/Kconfig @@ -168,4 +168,14 @@
endif # HAVE_REFCODE_BLOB
+config VGA_BIOS_ID + string + depends on VGA_BIOS + default "8086,0f31" + +config VGA_BIOS_FILE + string + depends on VGA_BIOS + default "pci8086,0f31.rom" + endif
-
HAOUAS Elyes (Code Review) -
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)