Change in coreboot[master]: mb/system76/lemp9: enable SA thermal device

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: mb/*:...

Jeremy Soller (Code Review)

20 Jul 2020 20 Jul '20

11:32 p.m.

Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

mb/system76/lemp9: enable SA thermal device

Tested on lemp9, SA thermal device appears in lspci

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43628/1

diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 2ad0904..2d5b38f 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -150,7 +150,7 @@ register "PcieClkSrcClkReq[5]" = "5"

# Misc - register "Device4Enable" = "0" + register "Device4Enable" = "1" register "HeciEnabled" = "0" register "Heci3Enabled" = "0" register "AcousticNoiseMitigation" = "1" @@ -203,7 +203,7 @@ device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device - device pci 04.0 off end # SA Thermal device + device pci 04.0 on end # SA Thermal device device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS device pci 12.6 off end # GSPI #2

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Angel Pons (Code Review)

21 Jul 21 Jul

12:02 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

Patch Set 6: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43628/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43628/6//COMMIT_MSG@9 PS6, Line 9: Tested on lemp9, SA thermal device appears in lspci Please add a period at the end of the sentence.

Jeremy Soller (Code Review)

12:02 a.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43628

to look at the new patch set (#7).

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

mb/system76/lemp9: enable SA thermal device

Tested on lemp9, SA thermal device appears in lspci

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43628/7

Jeremy Soller (Code Review)

12:11 a.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43628

to look at the new patch set (#8).

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

mb/system76/lemp9: enable SA thermal device

Tested on lemp9, SA thermal device appears in lspci.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43628/8

Michael Niewöhner (Code Review)

12:15 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

Patch Set 8: Code-Review+1

Jeremy Soller (Code Review)

4:20 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43628

to look at the new patch set (#12).

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

mb/system76/lemp9: enable SA thermal device

Tested on lemp9, SA thermal device appears in lspci.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43628/12

Michael Niewöhner (Code Review)

5:48 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

Patch Set 15:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43628/15//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43628/15//COMMIT_MSG@7 PS15, Line 7: mb/system76/lemp9: enable SA thermal device Just found something interesting... Newer datasheets call it "DPPM" which seems to be part of DPTF. see https://01.org/intel%C2%AE-dynamic-platform-and-thermal-framework-dptf-chrom...

So there are two questions: 1) what does it do when dptf is not enabled/supported? 2) what does enabling do anyways?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 15 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 15:48:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

5:49 p.m.

Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

Patch Set 15:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43628/15//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43628/15//COMMIT_MSG@7 PS15, Line 7: mb/system76/lemp9: enable SA thermal device

...

Just found something interesting... Newer datasheets call it "DPPM" which seems to be part of DPTF. […]

Enabling it allows Linux to view and set TCC, see drivers/thermal/intel/intel_pch_thermal.c in Linux

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 15 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 15:49:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

5:52 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

Patch Set 15: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 15 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 15:52:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jeremy Soller (Code Review)

22 Jul 22 Jul

2:45 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43628

to look at the new patch set (#16).

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

mb/system76/lemp9: enable SA thermal device

Tested on lemp9, SA thermal device appears in lspci.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43628/16

Jeremy Soller (Code Review)

4:09 p.m.

Hello build bot (Jenkins), Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43628

to look at the new patch set (#18).

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

mb/system76/lemp9: enable SA thermal device

Tested on lemp9, SA thermal device appears in lspci.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43628/18

Sumeet R Pawnikar (Code Review)

23 Jul 23 Jul

10:28 a.m.

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

Patch Set 18:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43628/18//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43628/18//COMMIT_MSG@9 PS18, Line 9: Tested on lemp9, SA thermal device appears in lspci. If you add output of lspci for this particular thermal device as result here, that would be helpful.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 18 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Comment-Date: Thu, 23 Jul 2020 08:28:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

26 Jul 26 Jul

10:01 p.m.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

Patch Set 19:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... PS19, Line 142: register "Device4Enable" = "1" Please move this down to the devicetree.

https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... PS19, Line 195: device pci 04.0 on end # SA Thermal device ``` device pci 04.0 on # SA Thermal device register "Device4Enable" = "1" end ```

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Comment-Date: Sun, 26 Jul 2020 20:01:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

10:05 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

Patch Set 19:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... PS19, Line 195: device pci 04.0 on end # SA Thermal device

...

The reason to do this is that it allows one to quickly see that both settings match.

device pci 04.0 on # SA Thermal device register "Device4Enable" = "1" end

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Felix Singer felixsinger@posteo.net Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Comment-Date: Sun, 26 Jul 2020 20:05:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Gerrit-MessageType: comment

Felix Singer (Code Review)

6 Sep 6 Sep

1:41 a.m.

Felix Singer has uploaded a new patch set (#20) to the change originally created by Jeremy Soller. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: enable SA thermal device ......................................................................

mb/system76/lemp9: enable SA thermal device

Tested on lemp9, SA thermal device appears in lspci.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43628/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 20 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

1:42 a.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Enable SA thermal device

Felix Singer has uploaded a new patch set (#21) to the change originally created by Jeremy Soller. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: Enable SA thermal device ......................................................................

mb/system76/lemp9: Enable SA thermal device

Tested on lemp9, SA thermal device appears in lspci.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43628/21

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

1:44 a.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Enable SA thermal device

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: Enable SA thermal device ......................................................................

Patch Set 21:

(4 comments)

https://review.coreboot.org/c/coreboot/+/43628/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43628/6//COMMIT_MSG@9 PS6, Line 9: Tested on lemp9, SA thermal device appears in lspci

...

Please add a period at the end of the sentence.

Done

https://review.coreboot.org/c/coreboot/+/43628/18//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43628/18//COMMIT_MSG@9 PS18, Line 9: Tested on lemp9, SA thermal device appears in lspci.

...

If you add output of lspci for this particular thermal device as result here, that would be helpful.

Done

https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... PS19, Line 142: register "Device4Enable" = "1"

...

Please move this down to the devicetree.

Done

https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... PS19, Line 195: device pci 04.0 on end # SA Thermal device

...

The reason to do this is that it allows one to quickly see that both settings match. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Comment-Date: Sat, 05 Sep 2020 23:44:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Comment-In-Reply-To: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Felix Singer (Code Review)

1:51 a.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Enable SA thermal device

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: Enable SA thermal device ......................................................................

Patch Set 21: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Comment-Date: Sat, 05 Sep 2020 23:51:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

4:40 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Enable SA thermal device

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: Enable SA thermal device ......................................................................

Patch Set 21: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 21 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Comment-Date: Sun, 06 Sep 2020 14:40:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

4:40 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: Enable SA thermal device

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43628 )

Change subject: mb/system76/lemp9: Enable SA thermal device ......................................................................

mb/system76/lemp9: Enable SA thermal device

Tested on lemp9, SA thermal device appears in lspci.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43628 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Michael Niewöhner --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Michael Niewöhner: Looks good to me, approved

diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index c0a2835..da96dd3 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -179,8 +179,8 @@ device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device - device pci 04.0 off # SA Thermal device - register "Device4Enable" = "0" + device pci 04.0 on # SA Thermal device + register "Device4Enable" = "1" end device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS

-- To view, visit https://review.coreboot.org/c/coreboot/+/43628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I527e586b1dae5f8087d2364c63c9db5bcb643214 Gerrit-Change-Number: 43628 Gerrit-PatchSet: 22 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-MessageType: merged

1539

days inactive

1587

days old

coreboot-gerrit@coreboot.org

19 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Felix Singer (Code Review)
Jeremy Soller (Code Review)
Michael Niewöhner (Code Review)
Sumeet R Pawnikar (Code Review)