John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
mb/google/zork/var/vilboz: update dptc stapm time
Update dptc setting: Stapm_time_constant 1400
BRANCH=zork TEST=emerge coreboot and check "Stapm_time_constant"
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: I61d9e00a9d098ad9699b8cf89e70d11de2b95ffd --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/46048/1
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index 3d9ff7c..73db6fd 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -13,7 +13,7 @@ register "slow_ppt_limit" = "6000" # mW register "fast_ppt_limit" = "9000" # mW register "slow_ppt_time_constant" = "5" # second - register "stapm_time_constant" = "2500" # second + register "stapm_time_constant" = "1400" # second register "sustained_power_limit" = "4800" # mW
# End : OPN Performance Configuration
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
Patch Set 4:
If you're going to change the stapm_time_constant and not only for tablet or clamshell mode. you can only change the "stapm_time_constant" = "2500" to"1400"
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v... PS4, Line 4: : /* Enable DPTC support */ : #define EC_ENABLE_AMD_DPTC_SUPPORT If this change is not only for tablet mode. I think that it wouldn't add this define.
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v... PS4, Line 19: register "dptc_enable" = "1" : register "slow_ppt_limit_tablet_mode" = "6000" #mw : register "fast_ppt_limit_tablet_mode" = "9000" #mw : register "stapm_time_constant_tablet_mode" = "1400" #second : register "sustained_power_limit_tablet_mode" = "4800" #mw those parameter is used for tablet mode specific. If you're not only modify for tablet mode, I think those item is not necessary.
Hello build bot (Jenkins), chris wang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46048
to look at the new patch set (#5).
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
mb/google/zork/var/vilboz: update dptc stapm time
Update dptc setting: Stapm_time_constant 1400
BUG=b:170696020 BRANCH=zork TEST=emerge coreboot and check "Stapm_time_constant"
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: I61d9e00a9d098ad9699b8cf89e70d11de2b95ffd --- M src/mainboard/google/zork/variants/vilboz/include/variant/ec.h M src/mainboard/google/zork/variants/vilboz/overridetree.cb 2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/46048/5
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
Patch Set 5: Code-Review+1
This change is ready for review.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v... PS4, Line 4: : /* Enable DPTC support */ : #define EC_ENABLE_AMD_DPTC_SUPPORT
If this change is not only for tablet mode. I think that it wouldn't add this define.
We don't switch tablet and clamshell mode from our thermal team confirm. I will change this patch again.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v... PS4, Line 4: : /* Enable DPTC support */ : #define EC_ENABLE_AMD_DPTC_SUPPORT
We don't switch tablet and clamshell mode from our thermal team confirm. […]
Done
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v... PS4, Line 19: register "dptc_enable" = "1" : register "slow_ppt_limit_tablet_mode" = "6000" #mw : register "fast_ppt_limit_tablet_mode" = "9000" #mw : register "stapm_time_constant_tablet_mode" = "1400" #second : register "sustained_power_limit_tablet_mode" = "4800" #mw
those parameter is used for tablet mode specific. […]
Done
Hello build bot (Jenkins), Furquan Shaikh, chris wang, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46048
to look at the new patch set (#6).
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
mb/google/zork/var/vilboz: update dptc stapm time
Update dptc setting: Stapm_time_constant 1400
BUG=b:170696020 BRANCH=zork TEST=emerge coreboot and check "Stapm_time_constant"
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: I61d9e00a9d098ad9699b8cf89e70d11de2b95ffd --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/46048/6
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
Patch Set 6: Code-Review+1
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
Patch Set 7: Code-Review+1
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
Patch Set 7: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time ......................................................................
mb/google/zork/var/vilboz: update dptc stapm time
Update dptc setting: Stapm_time_constant 1400
BUG=b:170696020 BRANCH=zork TEST=emerge coreboot and check "Stapm_time_constant"
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: I61d9e00a9d098ad9699b8cf89e70d11de2b95ffd Reviewed-on: https://review.coreboot.org/c/coreboot/+/46048 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Chris Wang chris.wang@amd.corp-partner.google.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified John Su: Looks good to me, but someone else must approve Chris Wang: Looks good to me, but someone else must approve EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index b75beaf..a93beb5 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -13,7 +13,7 @@ register "slow_ppt_limit" = "6000" # mW register "fast_ppt_limit" = "9000" # mW register "slow_ppt_time_constant" = "5" # second - register "stapm_time_constant" = "2500" # second + register "stapm_time_constant" = "1400" # second register "sustained_power_limit" = "4800" # mW
# End : OPN Performance Configuration
-
Chris Wang (Code Review) -
EricR Lai (Code Review)
-
John Su (Code Review)
-
Patrick Georgi (Code Review)