Attention is currently required from: Martin L Roth, Matt DeVillier, Fred Reitberger, Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74150 )
Change subject: Makefile.inc: introduce all_x86 target ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74150/comment/7dd91a1a_2e9ffe3e PS1, Line 14: verstage_x8
nit: verstage_x86
Done
https://review.coreboot.org/c/coreboot/+/74150/comment/f3792708_36ba833b PS1, Line 19: per
nit: pre-Zen?
Done
Patchset:
PS1:
CB:74152 uses this in src/cpu where the verstage_x86 target and the other stage targets were used. […]
i'll try to look into using all_x86 in arch/x86 and cpu/x86. might be useful to use that instead of the all in all makefiles in those two directories
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74150/comment/4f107513_3a1a9d98 PS1, Line 117: $(call add-special-class,all_x86) : all_x86-handler = $(foreach class,bootblock verstage_x86 romstage postcar ramstage,$(eval $(class)-y += $(2)))
looks like this needs to go above the expansion for verstage_x86 above
moved this above the verstage_86 expansion; let's see if jenkins now like the next patches better
-
Felix Held (Code Review)