Change in coreboot[master]: soc/intel/common: Include cometlake EMMC controller ID

List overview All Threads
Download

newer

older

Change in coreboot[master]: Split...

Change in coreboot[master]:...

Jamie Chen (Code Review)

26 Aug 2019 26 Aug '19

12:55 p.m.

Jamie Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35093 )

Change subject: soc/intel/common: Include cometlake EMMC controller ID ......................................................................

soc/intel/common: Include cometlake EMMC controller ID

Add cometlake EMMC controller ID

BUG=none BRANCH=none TEST=none

Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Signed-off-by: Jamie Chen jamie.chen@intel.com --- M src/include/device/pci_ids.h 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35093/1

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 2501640..b4cbc38 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3221,6 +3221,7 @@ #define PCI_DEVICE_ID_INTEL_CNP_H_SD 0xa375 #define PCI_DEVICE_ID_INTEL_ICL_SD 0x34f8 #define PCI_DEVICE_ID_INTEL_CMP_SD 0x02f5 +#define PCI_DEVICE_ID_INTEL_CMP_MMC 0x02c4

/* Intel EMMC device Ids */ #define PCI_DEVICE_ID_INTEL_SKL_EMMC 0x9d2b

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Subrata Banik (Code Review)

26 Aug 26 Aug

3:27 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35093 )

Change subject: soc/intel/common: Include cometlake EMMC controller ID ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35093/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:

https://review.coreboot.org/c/coreboot/+/35093/1/src/include/device/pci_ids.... PS1, Line 3224: PCI_DEVICE_ID_INTEL_CMP_MMC can you add this at line 3228?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Gerrit-Change-Number: 35093 Gerrit-PatchSet: 1 Gerrit-Owner: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kane Chen kane.chen@intel.com Gerrit-Comment-Date: Mon, 26 Aug 2019 13:27:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kane Chen (Code Review)

4:39 p.m.

Kane Chen has uploaded a new patch set (#2) to the change originally created by Jamie Chen. ( https://review.coreboot.org/c/coreboot/+/35093 )

Change subject: soc/intel/common: Include cometlake EMMC controller ID ......................................................................

soc/intel/common: Include cometlake EMMC controller ID

Add cometlake EMMC controller ID

BUG=none BRANCH=none TEST=none

Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Signed-off-by: Jamie Chen jamie.chen@intel.com --- M src/include/device/pci_ids.h 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35093/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Gerrit-Change-Number: 35093 Gerrit-PatchSet: 2 Gerrit-Owner: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Subrata Banik (Code Review)

4:43 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35093 )

Change subject: soc/intel/common: Include cometlake EMMC controller ID ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/35093/2/src/include/device/pci_ids.... File src/include/device/pci_ids.h:

https://review.coreboot.org/c/coreboot/+/35093/2/src/include/device/pci_ids.... PS2, Line 3227: #define PCI_DEVICE_ID_INTEL_CMP_MMC 0x02c4 this could be PCI_DEVICE_ID_INTEL_CMP_EMMC just to make naming consistence across

-- To view, visit https://review.coreboot.org/c/coreboot/+/35093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Gerrit-Change-Number: 35093 Gerrit-PatchSet: 2 Gerrit-Owner: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 26 Aug 2019 14:43:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kane Chen (Code Review)

5:09 p.m.

Kane Chen has uploaded a new patch set (#3) to the change originally created by Jamie Chen. ( https://review.coreboot.org/c/coreboot/+/35093 )

Change subject: soc/intel/common: Include cometlake EMMC controller ID ......................................................................

soc/intel/common: Include cometlake EMMC controller ID

Add cometlake EMMC controller ID

BUG=none BRANCH=none TEST=none

Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Signed-off-by: Jamie Chen jamie.chen@intel.com --- M src/include/device/pci_ids.h 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35093/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/35093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Gerrit-Change-Number: 35093 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Subrata Banik (Code Review)

5:32 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35093 )

Change subject: soc/intel/common: Include cometlake EMMC controller ID ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Gerrit-Change-Number: 35093 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 26 Aug 2019 15:32:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Subrata Banik (Code Review)

5:33 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35093 )

Change subject: soc/intel/common: Include cometlake EMMC controller ID ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35093/2/src/include/device/pci_ids.... File src/include/device/pci_ids.h:

https://review.coreboot.org/c/coreboot/+/35093/2/src/include/device/pci_ids.... PS2, Line 3227: #define PCI_DEVICE_ID_INTEL_CMP_MMC 0x02c4

...

this could be PCI_DEVICE_ID_INTEL_CMP_EMMC just to make naming consistence across

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/35093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Gerrit-Change-Number: 35093 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 26 Aug 2019 15:33:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Gerrit-MessageType: comment

Subrata Banik (Code Review)

5:33 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35093 )

Change subject: soc/intel/common: Include cometlake EMMC controller ID ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35093/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:

https://review.coreboot.org/c/coreboot/+/35093/1/src/include/device/pci_ids.... PS1, Line 3224: PCI_DEVICE_ID_INTEL_CMP_MMC

...

can you add this at line 3228?

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/35093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Gerrit-Change-Number: 35093 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 26 Aug 2019 15:33:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:13 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35093 )

Change subject: soc/intel/common: Include cometlake EMMC controller ID ......................................................................

soc/intel/common: Include cometlake EMMC controller ID

Add cometlake EMMC controller ID

BUG=none BRANCH=none TEST=none

Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Signed-off-by: Jamie Chen jamie.chen@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35093 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/include/device/pci_ids.h 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 2501640..cdd1c62 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3224,6 +3224,7 @@

/* Intel EMMC device Ids */ #define PCI_DEVICE_ID_INTEL_SKL_EMMC 0x9d2b +#define PCI_DEVICE_ID_INTEL_CMP_EMMC 0x02c4

/* Intel WIFI Ids */ #define PCI_DEVICE_ID_1000_SERIES_WIFI 0x0084

-- To view, visit https://review.coreboot.org/c/coreboot/+/35093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3943dad57918df3df7885c2e2d3a86ab0e1d6008 Gerrit-Change-Number: 35093 Gerrit-PatchSet: 4 Gerrit-Owner: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Chen jamie.chen@intel.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1916

days inactive

1916

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Jamie Chen (Code Review)
Kane Chen (Code Review)
Patrick Georgi (Code Review)
Subrata Banik (Code Review)