Change in ...coreboot[master]: nuvoton/early_serial: improve comments on serial pinmux settings
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33665
Change subject: nuvoton/early_serial: improve comments on serial pinmux settings ......................................................................
nuvoton/early_serial: improve comments on serial pinmux settings
Change-Id: I36c0d752df97810bd99d2eec27403545421ce533 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/nuvoton/common/early_serial.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/33665/1
diff --git a/src/superio/nuvoton/common/early_serial.c b/src/superio/nuvoton/common/early_serial.c index 7f22993..eaa3c5a 100644 --- a/src/superio/nuvoton/common/early_serial.c +++ b/src/superio/nuvoton/common/early_serial.c @@ -66,11 +66,11 @@ nuvoton_pnp_enter_conf_state(dev);
if (CONFIG(SUPERIO_NUVOTON_NCT6776_COM_A)) - /* Route GPIO8 pin group to COM A */ + /* Route COM A to GPIO8 pin group */ pnp_write_config(dev, 0x2a, 0x40);
if (CONFIG(SUPERIO_NUVOTON_NCT6791D_COM_A)) - /* Route GPIO8 pin group to COM A */ + /* Route COM A to GPIO8 pin group */ pnp_write_config(dev, 0x2a, 0x00);
pnp_set_logical_device(dev);
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33665 )
Change subject: nuvoton/early_serial: improve comments on serial pinmux settings ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33665 )
Change subject: nuvoton/early_serial: improve comments on serial pinmux settings ......................................................................
nuvoton/early_serial: improve comments on serial pinmux settings
Change-Id: I36c0d752df97810bd99d2eec27403545421ce533 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/33665 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/superio/nuvoton/common/early_serial.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/superio/nuvoton/common/early_serial.c b/src/superio/nuvoton/common/early_serial.c index 7f22993..eaa3c5a 100644 --- a/src/superio/nuvoton/common/early_serial.c +++ b/src/superio/nuvoton/common/early_serial.c @@ -66,11 +66,11 @@ nuvoton_pnp_enter_conf_state(dev);
if (CONFIG(SUPERIO_NUVOTON_NCT6776_COM_A)) - /* Route GPIO8 pin group to COM A */ + /* Route COM A to GPIO8 pin group */ pnp_write_config(dev, 0x2a, 0x40);
if (CONFIG(SUPERIO_NUVOTON_NCT6791D_COM_A)) - /* Route GPIO8 pin group to COM A */ + /* Route COM A to GPIO8 pin group */ pnp_write_config(dev, 0x2a, 0x00);
pnp_set_logical_device(dev);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33665 )
Change subject: nuvoton/early_serial: improve comments on serial pinmux settings ......................................................................
Patch Set 2: Code-Review+2
Just saw this now, my bad.
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)