Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58430 )
Change subject: soc/intel/alderlake: Fix wrong FIVR configs assignment ......................................................................
soc/intel/alderlake: Fix wrong FIVR configs assignment
For PchFivrExtVnnRailSxEnabledStates, vnn_enable_bitmap config is used by mistake, instead of the expected vnn_sx_enable_bitmap
Signed-off-by: Bora Guvendik bora.guvendik@intel.com Change-Id: Idf100be3ac4d6d97335c627e790c1870558d1210 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58430 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 6e90cf1..9ed8acd 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -712,7 +712,7 @@ config->ext_fivr_settings.vnn_supported_voltage_bitmap;
s_cfg->PchFivrExtVnnRailSxEnabledStates = - config->ext_fivr_settings.vnn_enable_bitmap; + config->ext_fivr_settings.vnn_sx_enable_bitmap;
/* Convert the voltages to increments of 2.5mv */ s_cfg->PchFivrExtV1p05RailVoltage =