Attention is currently required from: Paul Menzel, Patrick Rudolph. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62008 )
Change subject: drivers/intel/i210: Set log level to BIOS_NOTICE on missing MAC address ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62008/comment/4fa87d77_13ee12e0 PS1, Line 12:
- Notice if no `hwinfo.hex` is present, saying that one should be deployed for proper network card operation.
This is part of the hwilib already, so no need to add this one twice, see [1]
- Show an error if the MAC address is invalid.
If there is no valid MAC address in hwinfo.hex then the MAC will keep the one which is already programmed by the inital i210 firmware image. So there is no case where we end up with no MAC address at all, it will just be the default one. Therefor just notify in the log that the default MAC address will be used.
[1]: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...