Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Arthur Heymans, Morgan Jang.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49457 )
Change subject: intel/xeon_sp, mb/ocp/deltalake: Rework get_stack_busnos()
......................................................................
Patch Set 12:
(1 comment)
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/49457/comment/5622f08e_0c8ac8e7
PS11, Line 23: const uint32_t reg32 = pci_io_read_config32(dev,
: stack / 4 ? UBOX_DECS_CPUBUSNO1_CSR : UBOX_DECS_CPUBUSNO_CSR);
: return reg32 >> (8 * (stack % 4)) & 0xff;
Uh yes, well spotted. Adding `stack / 4` would not work. Sorry. […]
I think your variant looks better. Thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49457
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e78e31b8ab89b1bdcfdeffae2e193e698385186
Gerrit-Change-Number: 49457
Gerrit-PatchSet: 12
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Comment-Date: Mon, 18 Jan 2021 23:33:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment