Change in coreboot[master]: src/include/asan.h: include stdint.h

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44658 )

Change subject: src/include/asan.h: include stdint.h
......................................................................

src/include/asan.h: include stdint.h

It's required because the header uses uintptr_t, defined there.

Change-Id: Ibefe96c8d502b6d71ba92bd04f543886010fde22
Signed-off-by: Patrick Georgi 
---
M src/include/asan.h
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/44658/1

diff --git a/src/include/asan.h b/src/include/asan.h
index 1fe798d..ae9f1df 100644
--- a/src/include/asan.h
+++ b/src/include/asan.h
@@ -3,6 +3,8 @@
 #ifndef __ASAN_H
 #define __ASAN_H

+#include <stdint.h>
+
 #define ASAN_SHADOW_SCALE_SHIFT 3

#define ASAN_SHADOW_SCALE_SIZE	(1UL << ASAN_SHADOW_SCALE_SHIFT)

[Harshit Sharma (Code Review)]

Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44658 )

Change subject: src/include/asan.h: include stdint.h
......................................................................

Patch Set 1:

Thanks for the fix. We already have stdint.h in memset.c. So, don't you think it would be better to just include this in memcpy.c and memmove.c as well?

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44658 )

Change subject: src/include/asan.h: include stdint.h
......................................................................

Patch Set 1:
> Patch Set 1:
>
> Thanks for the fix. We already have stdint.h in memset.c. So, don't you think it would be better to just include this in memcpy.c and memmove.c as well?

Since the header itself is using uintptr_t, I think it should also include stdint.h. If memcpy or memmove also use it, they should _also_ include it (and the header guard in stdint.h ensures that it's only evaluated once).

[Harshit Sharma (Code Review)]

Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44658 )

Change subject: src/include/asan.h: include stdint.h
......................................................................

Patch Set 1: Code-Review+1
> Patch Set 1:
> > Patch Set 1:
> >
> > Thanks for the fix. We already have stdint.h in memset.c. So, don't you think it would be better to just include this in memcpy.c and memmove.c as well?
>
> Since the header itself is using uintptr_t, I think it should also include stdint.h. If memcpy or memmove also use it, they should _also_ include it (and the header guard in stdint.h ensures that it's only evaluated once).

Got it.

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44658 )

Change subject: src/include/asan.h: include stdint.h
......................................................................

Patch Set 1: Code-Review+2

This unbreaks the tree (tested with unselecting a payload) on ubuntu.

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44658 )

Change subject: src/include/asan.h: include stdint.h
......................................................................

Patch Set 1: Code-Review-1

size_t is defined in stddef.h, not stdint.h
CB:44656 doesn't have this problem

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44658 )

Change subject: src/include/asan.h: include stdint.h
......................................................................

Patch Set 1: -Code-Review

[Patrick Georgi (Code Review)]

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44658 )

Change subject: src/include/asan.h: include stdint.h
......................................................................

Abandoned