Patch Set 1:

Thanks for the fix. We already have stdint.h in memset.c. So, don't you think it would be better to just include this in memcpy.c and memmove.c as well?

Since the header itself is using uintptr_t, I think it should also include stdint.h. If memcpy or memmove also use it, they should _also_ include it (and the header guard in stdint.h ensures that it's only evaluated once).

View Change

To view, visit change 44658. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibefe96c8d502b6d71ba92bd04f543886010fde22
Gerrit-Change-Number: 44658
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Harshit Sharma <harshitsharmajs@gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 21 Aug 2020 10:24:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment