Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49389 )
Change subject: nb/intel/x4x: Drop commented-out statement ......................................................................
nb/intel/x4x: Drop commented-out statement
Time has proven this statement to be unnecessary. Uncommenting it would not have any effect on the existing code, thus remove it completely.
Change-Id: Iff4cdd71435e4fd69d4f3284e9fb2830fdd5b173 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49389 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/x4x/raminit_ddr23.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/x4x/raminit_ddr23.c b/src/northbridge/intel/x4x/raminit_ddr23.c index fc39a5d..119eccd 100644 --- a/src/northbridge/intel/x4x/raminit_ddr23.c +++ b/src/northbridge/intel/x4x/raminit_ddr23.c @@ -776,8 +776,6 @@ ~rank2clken[r + i * 4]); } } - - //reg8 = 0x00; // FIXME don't switch on all clocks anyway } /* END EACH CHANNEL */
if (s->spd_type == DDR2) {