Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47570 )
Change subject: nb/intel/sandybridge: Correct some whitespace issues ......................................................................
nb/intel/sandybridge: Correct some whitespace issues
Add a missing tab and remove spurious spaces in the IOSAV structs.
Change-Id: If588d3f01c8744fd0c83576a56cfdda2fb43a3bd Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/47570/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index f9f1f7d..697167a 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -660,7 +660,7 @@ /* DRAM command MRS */ [2] = { .sp_cmd_ctrl = { - .command = IOSAV_MRS, + .command = IOSAV_MRS, }, .subseq_ctrl = { .cmd_executions = 1, @@ -831,7 +831,7 @@ /* DRAM command NOP (without ODT nor chip selects) */ [0] = { .sp_cmd_ctrl = { - .command = IOSAV_NOP & ~(0xff << 8), + .command = IOSAV_NOP & ~(0xff << 8), }, .subseq_ctrl = { .cmd_executions = 1, @@ -865,8 +865,8 @@ .rank = 0, }, .addr_update = { - .inc_rank = 1, - .addr_wrap = 20, + .inc_rank = 1, + .addr_wrap = 20, }, }, }; @@ -1506,7 +1506,7 @@ .rank = slotrank, }, .addr_update = { - .addr_wrap = 18, + .addr_wrap = 18, }, }, }; @@ -2294,7 +2294,7 @@ }
FOR_ALL_POPULATED_CHANNELS - program_timings(ctrl, channel); + program_timings(ctrl, channel);
reprogram_320c(ctrl); return 0; @@ -2893,7 +2893,7 @@ .rank = slotrank, }, .addr_update = { - .addr_wrap = 18, + .addr_wrap = 18, }, }, };
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47570 )
Change subject: nb/intel/sandybridge: Correct some whitespace issues ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47570 )
Change subject: nb/intel/sandybridge: Correct some whitespace issues ......................................................................
nb/intel/sandybridge: Correct some whitespace issues
Add a missing tab and remove spurious spaces in the IOSAV structs.
Change-Id: If588d3f01c8744fd0c83576a56cfdda2fb43a3bd Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47570 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 7 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 3ed1a3a..49168a9 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -650,7 +650,7 @@ /* DRAM command MRS */ [2] = { .sp_cmd_ctrl = { - .command = IOSAV_MRS, + .command = IOSAV_MRS, }, .subseq_ctrl = { .cmd_executions = 1, @@ -821,7 +821,7 @@ /* DRAM command NOP (without ODT nor chip selects) */ [0] = { .sp_cmd_ctrl = { - .command = IOSAV_NOP & ~(0xff << 8), + .command = IOSAV_NOP & ~(0xff << 8), }, .subseq_ctrl = { .cmd_executions = 1, @@ -855,8 +855,8 @@ .rank = 0, }, .addr_update = { - .inc_rank = 1, - .addr_wrap = 20, + .inc_rank = 1, + .addr_wrap = 20, }, }, }; @@ -1496,7 +1496,7 @@ .rank = slotrank, }, .addr_update = { - .addr_wrap = 18, + .addr_wrap = 18, }, }, }; @@ -2282,7 +2282,7 @@ }
FOR_ALL_POPULATED_CHANNELS - program_timings(ctrl, channel); + program_timings(ctrl, channel);
reprogram_320c(ctrl); return 0; @@ -2881,7 +2881,7 @@ .rank = slotrank, }, .addr_update = { - .addr_wrap = 18, + .addr_wrap = 18, }, }, };
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)