Attention is currently required from: Tarun Tuli, Kangheui Won, Ren Kuo, Tyler Wang.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69958 )
Change subject: [WIP] mb/google/nissa/var/craask: Add support for NVMe GPIOs
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/craask/gpio.c:
https://review.coreboot.org/c/coreboot/+/69958/comment/a7171549_a63444a4
PS1, Line 15: GPP_D6
OK. […]
If you want to use a shared firmware target, then the pins should be kept as similar as possible between variants. Supporting different pin assignments based on board_id is not something we support in general. nivviks/nirwen was a special case.
We can always switch to board_id if really needed in the future, but I think this is fine for now, and we should try to make sure future hardware changes can be supported by fw_config too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76a056cddff2246cfb5bb26ddbdfc333b49d9aaf
Gerrit-Change-Number: 69958
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 24 Nov 2022 05:26:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment