Change in coreboot[master]: src/mb/intel/tglrvp: Use the MCON and MCOF methods for clock control

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39500 )

Change subject: src/mb/intel/tglrvp: Use the MCON and MCOF methods for clock control
......................................................................

src/mb/intel/tglrvp: Use the MCON and MCOF methods for clock control

Use the MCON and MCOF methods for camera clock control

BUG=None
BRANCH=None
TEST=Yet to test

Signed-off-by: Rizwan Qureshi 
Change-Id: Ie136cd4497e2368c586640dc5afc5051f4483c50
---
M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/39500/1

diff --git a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl
index c830ea1..5d42a29 100644
--- a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl
+++ b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl
@@ -177,7 +177,7 @@
    		If ((STA == Zero))
    		{
    			/* Enable CLK0 with 19.2MHz */
-				MCCT(0,1,1)
+				MCON(0,1)
    			/* Pull PWREN(GPIO B23) high */
    			STXS(GPP_B23)
    			Sleep(5)
@@ -200,7 +200,7 @@
    			/* Pull PWREN low */
    			CTXS(GPP_B23)
    			/* Disable CLK0 */
-				MCCT(0,0,1)
+				MCOF(0)
    			Store(0,STA)
    		}
    	}
@@ -380,7 +380,7 @@
    		If ((STA == Zero))
    		{
    			/* Enable CLK1 with 19.2MHz */
-				MCCT(1,1,1)
+				MCON(1,1)
    			/* Pull PWREN(GPIO R6) high */
    			STXS(GPP_R6)
    			Sleep(5)
@@ -403,7 +403,7 @@
    			/* Pull PWREN low */
    			CTXS(GPP_R6)
    			/* Disable CLK1 */
-				MCCT(1,0,1)
+				MCOF(1)
    			Store(0,STA)
    		}
    	}

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39500 )

Change subject: src/mb/intel/tglrvp: Use the MCON and MCOF methods for clock control
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39500/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39500/1//COMMIT_MSG@7 
PS1, Line 7: src/mb/intel/tglrvp: Use the MCON and MCOF methods for clock control
1.  Please remove `src/` from the prefix.
2.  The article *the* is not needed.

https://review.coreboot.org/c/coreboot/+/39500/1//COMMIT_MSG@9 
PS1, Line 9: Use the MCON and MCOF methods for camera clock control
You can remove this, as it is the same as the commit message summary.

https://review.coreboot.org/c/coreboot/+/39500/1/src/mainboard/intel/tglrvp/... 
File src/mainboard/intel/tglrvp/acpi/mipi_camera.asl:

https://review.coreboot.org/c/coreboot/+/39500/1/src/mainboard/intel/tglrvp/... 
PS1, Line 180: 				MCON(0,1)
Please add a space after the comma.

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39500 )

Change subject: src/mb/intel/tglrvp: Use the MCON and MCOF methods for clock control
......................................................................

Abandoned