Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40958 )
Change subject: nb/intel/i440bx: Drop northbridge.h ......................................................................
nb/intel/i440bx: Drop northbridge.h
It declares a function that was either never or no longer implemented.
Change-Id: I714d39374519bff1afb94870d0e84f57db619a1f Signed-off-by: Keith Hui buurin@gmail.com --- M src/northbridge/intel/i440bx/northbridge.c D src/northbridge/intel/i440bx/northbridge.h 2 files changed, 0 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/40958/1
diff --git a/src/northbridge/intel/i440bx/northbridge.c b/src/northbridge/intel/i440bx/northbridge.c index da0107c..d0c93fd 100644 --- a/src/northbridge/intel/i440bx/northbridge.c +++ b/src/northbridge/intel/i440bx/northbridge.c @@ -8,7 +8,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <cpu/cpu.h> -#include "northbridge.h" #include "i440bx.h"
static void northbridge_init(struct device *dev) diff --git a/src/northbridge/intel/i440bx/northbridge.h b/src/northbridge/intel/i440bx/northbridge.h deleted file mode 100644 index f42211e..0000000 --- a/src/northbridge/intel/i440bx/northbridge.h +++ /dev/null @@ -1,21 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef NORTHBRIDGE_INTEL_440BX_H -#define NORTHBRIDGE_INTEL_440BX_H - -extern unsigned int i440bx_scan_root_bus(struct device *root, unsigned int max); - -#endif /* NORTHBRIDGE_INTEL_440BX_H */
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40958 )
Change subject: nb/intel/i440bx: Drop northbridge.h ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40958 )
Change subject: nb/intel/i440bx: Drop northbridge.h ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40958 )
Change subject: nb/intel/i440bx: Drop northbridge.h ......................................................................
nb/intel/i440bx: Drop northbridge.h
It declares a function that was either never or no longer implemented.
Change-Id: I714d39374519bff1afb94870d0e84f57db619a1f Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40958 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/i440bx/northbridge.c D src/northbridge/intel/i440bx/northbridge.h 2 files changed, 0 insertions(+), 22 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/i440bx/northbridge.c b/src/northbridge/intel/i440bx/northbridge.c index da0107c..d0c93fd 100644 --- a/src/northbridge/intel/i440bx/northbridge.c +++ b/src/northbridge/intel/i440bx/northbridge.c @@ -8,7 +8,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <cpu/cpu.h> -#include "northbridge.h" #include "i440bx.h"
static void northbridge_init(struct device *dev) diff --git a/src/northbridge/intel/i440bx/northbridge.h b/src/northbridge/intel/i440bx/northbridge.h deleted file mode 100644 index f42211e..0000000 --- a/src/northbridge/intel/i440bx/northbridge.h +++ /dev/null @@ -1,21 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef NORTHBRIDGE_INTEL_440BX_H -#define NORTHBRIDGE_INTEL_440BX_H - -extern unsigned int i440bx_scan_root_bus(struct device *root, unsigned int max); - -#endif /* NORTHBRIDGE_INTEL_440BX_H */
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Keith Hui (Code Review)
-
Patrick Georgi (Code Review)