Change in coreboot[master]: drivers/i2c/da7219: Allow disabling micbias-pulse feature - coreboot-gerrit

23 Jul 2018


      Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/27613 )
Change subject: drivers/i2c/da7219: Allow disabling micbias-pulse feature
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27613/1/src/drivers/i2c/da7219/chip.h
File src/drivers/i2c/da7219/chip.h:
https://review.coreboot.org/#/c/27613/1/src/drivers/i2c/da7219/chip.h@5
PS1, Line 5: linux/Documentation/devicetree/bindings/sound/da7219.txt
As noted here, the parameters are documented in [0] which states that all of the da7219_aad child node properties are optional.
[0] https://www.kernel.org/doc/Documentation/devicetree/bindings/sound/da7219.tx...
-- 
To view, visit https://review.coreboot.org/27613
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9
Gerrit-Change-Number: 27613
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz djkurtz@google.com
Gerrit-Reviewer: Akshu Agrawal akshu.agrawal@amd.com
Gerrit-Reviewer: Daniel Kurtz djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 23 Jul 2018 23:37:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No