Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59361 )
Change subject: soc/intel/alderlake: Define a method to return a cpu type ......................................................................
Patch Set 1:
(4 comments)
File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/59361/comment/f517e680_ed8dd026 PS1, Line 65: static uint32_t cpu_get_family(void) : { : return cpuid_eax(1) & 0x0FFF0FF0; : } Use get_fms(). This is returning both family and model.
https://review.coreboot.org/c/coreboot/+/59361/comment/a953dcbe_9e23ef71 PS1, Line 83: & 0xFF Not needed
https://review.coreboot.org/c/coreboot/+/59361/comment/63bb8b9a_2fb693ba PS1, Line 83: UINT8 No UEFI types in coreboot.
https://review.coreboot.org/c/coreboot/+/59361/comment/1b3a8063_3252881a PS1, Line 84: ) : return CPUID_CORE_TYPE_INTEL_ATOM; : else : return CPUID_CORE_TYPE_INTEL_CORE; need {} on else statements if it's on the if one; https://doc.coreboot.org/contributing/coding_style.html#placing-braces-and-s...