Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85949?usp=email )
Change subject: soc/mediatek/mt8196: Add eDP driver ......................................................................
Patch Set 2:
(6 comments)
File src/soc/mediatek/mt8196/dp_intf.c:
https://review.coreboot.org/c/coreboot/+/85949/comment/70acb196_bbea1243?usp... : PS2, Line 160: remove the blank line
File src/soc/mediatek/mt8196/dptx.c:
https://review.coreboot.org/c/coreboot/+/85949/comment/9cca63e9_b9cc6416?usp... : PS2, Line 68: 3 DPTX_PREEMPHASIS3 ?
https://review.coreboot.org/c/coreboot/+/85949/comment/3a0a8c58_e95a1586?usp... : PS2, Line 194: = 0x0 not needed
File src/soc/mediatek/mt8196/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/85949/comment/eb9283a3_b735b9c0?usp... : PS2, Line 75: a A
File src/soc/mediatek/mt8196/include/soc/dptx.h:
https://review.coreboot.org/c/coreboot/+/85949/comment/a884971c_ad33240d?usp... : PS2, Line 8: #endif /* __SOC_MEDIATEK_MT8196_INCLUDE_SOC_DPTX_H__ */ one blank line before `#endif`
File src/soc/mediatek/mt8196/include/soc/dptx_hal.h:
https://review.coreboot.org/c/coreboot/+/85949/comment/d2a85092_5fb38e3f?usp... : PS2, Line 37: u8 align