Attention is currently required from: Sean Rhodes.
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69522 )
Change subject: mb/starlabs/starbook/kbl: Drop redundant option code ......................................................................
mb/starlabs/starbook/kbl: Drop redundant option code
Commit 9bbc039c457774dbeb44ea37ecc6507144d49b61 ("soc/intel/skylake: Hook up FSP hyper-threading setting to option API") already hooks up the `hyper_threading` CMOS option in SoC code, so there's no need to do it from mainboard code.
Change-Id: I602452266a8465cced12454f800ea023f382ba6f Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/starlabs/starbook/variants/kbl/romstage.c 1 file changed, 15 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/69522/1
diff --git a/src/mainboard/starlabs/starbook/variants/kbl/romstage.c b/src/mainboard/starlabs/starbook/variants/kbl/romstage.c index 098f753..72fe9ed 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/romstage.c @@ -19,8 +19,4 @@ mem_cfg->MemorySpdPtr00 = spd_cbfs_map(6); mem_cfg->MemorySpdPtr10 = mem_cfg->MemorySpdPtr00; mem_cfg->MemorySpdDataLen = CONFIG_DIMM_SPD_SIZE; - - const uint8_t ht = get_uint_option("hyper_threading", - mupd->FspmConfig.HyperThreading); - mupd->FspmConfig.HyperThreading = ht; }