Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60172 )
Change subject: soc/amd/cezanne/acpi: Add support for RTC workaround
......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/cezanne/acpi/rtc_workaround.asl:
https://review.coreboot.org/c/coreboot/+/60172/comment/d1a86734_112b0d29
PS2, Line 23: _E2C
I am not seeing a documentation for this method. […]
https://uefi.org/specs/ACPI/6.4/05_ACPI_Software_Programming_Model/ACPI_Soft...
https://review.coreboot.org/c/coreboot/+/60172/comment/c0ca0ba8_43ec56de
PS2, Line 24: _SB_
Is this extra underscore a typo?
It wasn't intentional, but I think it's fine. I think ACPI names that are shorter than 4 characters have the _ suffix appended as padding.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60172
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f14d14df5d30d48d244416f2ec8c10ac5c8040e
Gerrit-Change-Number: 60172
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mario Limonciello
mario.limonciello@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Mon, 20 Dec 2021 21:55:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment