Change in ...coreboot[master]: soc/intel/quark: Remove variable set but not used

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32912

Change subject: soc/intel/quark: Remove variable set but not used
......................................................................

soc/intel/quark: Remove variable set but not used

Change-Id: I09292c2776309982cfb4d72012991bf7725b75fb
Signed-off-by: Elyes HAOUAS 
---
M src/soc/intel/quark/i2c.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/32912/1

diff --git a/src/soc/intel/quark/i2c.c b/src/soc/intel/quark/i2c.c
index 595c818..49ebaa2 100644
--- a/src/soc/intel/quark/i2c.c
+++ b/src/soc/intel/quark/i2c.c
@@ -117,7 +117,6 @@
    int bytes_transferred;
    uint32_t cmd;
    int fifo_bytes;
-	uint8_t junk;
    I2C_REGS *regs;
    uint32_t status;

@@ -128,7 +127,7 @@
    /* Empty the FIFO */
    status = regs->ic_status;
    while (status & IC_STATUS_RFNE) {
-		junk = (uint8_t)regs->ic_data_cmd;
+		(uint8_t)regs->ic_data_cmd;
    	status = regs->ic_status;
    }

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32912 )

Change subject: soc/intel/quark: Remove variable set but not used
......................................................................

Abandoned

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/32912 )

Change subject: soc/intel/quark: Remove variable set but not used
......................................................................

Restored

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32912

to look at the new patch set (#2).

Change subject: soc/intel/quark: Remove variable set but not used
......................................................................

soc/intel/quark: Remove variable set but not used

Change-Id: I09292c2776309982cfb4d72012991bf7725b75fb
Signed-off-by: Elyes HAOUAS 
---
M src/soc/intel/quark/i2c.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/32912/2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32912 )

Change subject: soc/intel/quark: Remove variable set but not used
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/32912/5/src/soc/intel/quark/i2c.c 
File src/soc/intel/quark/i2c.c:

https://review.coreboot.org/#/c/32912/5/src/soc/intel/quark/i2c.c@a132 
PS5, Line 132: 
it's possible that this line exists to force a read on the data_cmd register. regs is of type I2C_REGS which is a volatile struct. Replace "junk = (uint8_t)" with "(void)" and we're good.

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32912 )

Change subject: soc/intel/quark: Remove variable set but not used
......................................................................

Patch Set 5:

(1 comment)

Thank you

https://review.coreboot.org/#/c/32912/5/src/soc/intel/quark/i2c.c 
File src/soc/intel/quark/i2c.c:

https://review.coreboot.org/#/c/32912/5/src/soc/intel/quark/i2c.c@a132 
PS5, Line 132:
> it's possible that this line exists to force a read on the data_cmd register. […]

Done

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32912

to look at the new patch set (#6).

Change subject: soc/intel/quark: Remove variable set but not used
......................................................................

soc/intel/quark: Remove variable set but not used

Change-Id: I09292c2776309982cfb4d72012991bf7725b75fb
Signed-off-by: Elyes HAOUAS 
---
M src/soc/intel/quark/i2c.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/32912/6

Change in coreboot[master]: soc/intel/quark: Remove variable set but not used

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32912 )

Change subject: soc/intel/quark: Remove variable set but not used
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: soc/intel/quark: Remove variable set but not used

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32912 )

Change subject: soc/intel/quark: Remove variable set but not used
......................................................................

soc/intel/quark: Remove variable set but not used

Change-Id: I09292c2776309982cfb4d72012991bf7725b75fb
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32912
Reviewed-by: Patrick Georgi 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/quark/i2c.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/src/soc/intel/quark/i2c.c b/src/soc/intel/quark/i2c.c
index bb1a264..b09852b 100644
--- a/src/soc/intel/quark/i2c.c
+++ b/src/soc/intel/quark/i2c.c
@@ -118,7 +118,6 @@
    int bytes_transferred;
    uint32_t cmd;
    int fifo_bytes;
-	uint8_t junk;
    I2C_REGS *regs;
    uint32_t status;

@@ -129,7 +128,7 @@
    /* Empty the FIFO */
    status = regs->ic_status;
    while (status & IC_STATUS_RFNE) {
-		junk = (uint8_t)regs->ic_data_cmd;
+		(void)regs->ic_data_cmd;
    	status = regs->ic_status;
    }