Attention is currently required from: Maulik V Vaghela, Sridhar Siricilla, Meera Ravindranath, Subrata Banik, Balaji Manigandan.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52186 )
Change subject: mb/intel/shadowmountain: Disable GSPI1 interface connected to FPS
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52186/comment/96ecd801_d5deb3fe
PS4, Line 9: The patch disables GSPI1 interface connected to fingerprint scanner.
why are we disabling it?
File src/mainboard/intel/shadowmountain/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52186/comment/e4dba568_1196a21b
PS4, Line 41: PAD_CFG_GPO(GPP_A21, 1, DEEP),
if the intent is to disable FPS, please disable the power as well, there is an on board FPS driver as well which will consume power.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52186
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic693a8c9699d7d1cceef9ca26305cc34498022d6
Gerrit-Change-Number: 52186
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Mon, 19 Apr 2021 17:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment