Change in coreboot[master]: [WIP]Allow to build romstage sources inside the bootblock - coreboot-gerrit

12 Jun 2021


      Attention is currently required from: Arthur Heymans, Martin Roth, ron minnich, Stefan Reinauer, Angel Pons, Keith Hui, Patrick Rudolph, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55068 )
Change subject: [WIP]Allow to build romstage sources inside the bootblock
......................................................................
Patch Set 4:
(1 comment)
File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/55068/comment/81d21d04_4ed7f0e0 
PS4, Line 37: #define ENV_ROMSTAGE !CONFIG(SEPARATE_ROMSTAGE)
...
Also incompatible setups like separate verstage and !separate romstage should be guarded against.
Good point, you should just add a Kconfig dependency for that.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id68390edc1ba228b121cca89b80c64a92553e284
Gerrit-Change-Number: 55068
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Hug philipp@hug.cx
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@chromium.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Branden Waldner scruffy99@gmail.com
Gerrit-CC: Keith Hui buurin@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: ron minnich rminnich@chromium.org
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Keith Hui buurin@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 11 Jun 2021 22:07:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment