Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40203 )
Change subject: mb/asus/p5gc-mx: Remove ACPI generic sleep button SLPB ......................................................................
mb/asus/p5gc-mx: Remove ACPI generic sleep button SLPB
Currently, Linux detects the ACPI generic sleep button SLPB defined by coreboot.
[ 8.720370] input: Sleep Button as /devices/LNXSYSTM:00/PNP0C0E:00/input/input2 [ 8.729081] ACPI: Sleep Button [SLPB]
But, this is a desktop board, and doesn’t have a sleep button. So, remove that probably copy-pasted ACPI device (gigabyte/ga-945gcm-s2l, intel/d945gclf)..
Fixes: 6390e525 ("mb/asus/p5gc-mx: Add mainboard") Change-Id: If2dbeb9238cbfe41f0f46f473000ac3629250fda Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/asus/p5gc-mx/acpi/mainboard.asl 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/40203/1
diff --git a/src/mainboard/asus/p5gc-mx/acpi/mainboard.asl b/src/mainboard/asus/p5gc-mx/acpi/mainboard.asl index 5187b2a..bb86c6c 100644 --- a/src/mainboard/asus/p5gc-mx/acpi/mainboard.asl +++ b/src/mainboard/asus/p5gc-mx/acpi/mainboard.asl @@ -12,14 +12,6 @@ * GNU General Public License for more details. */
-Device (SLPB) -{ - Name(_HID, EisaId("PNP0C0E")) - - // Wake - Name(_PRW, Package(){0x1d, 0x04}) -} - Device (PWRB) { Name(_HID, EisaId("PNP0C0C"))
Paul Menzel has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40203 )
Change subject: mb/asus/p5gc-mx: Remove ACPI generic sleep button SLPB ......................................................................
mb/asus/p5gc-mx: Remove ACPI generic sleep button SLPB
Currently, Linux detects the ACPI generic sleep button SLPB defined by coreboot.
[ 8.720370] input: Sleep Button as /devices/LNXSYSTM:00/PNP0C0E:00/input/input2 [ 8.729081] ACPI: Sleep Button [SLPB]
But, this is a desktop board, and doesn’t have a sleep button. So, remove that probably copy-pasted ACPI device (gigabyte/ga-945gcm-s2l, intel/d945gclf).
Fixes: 6390e525 ("mb/asus/p5gc-mx: Add mainboard") Change-Id: If2dbeb9238cbfe41f0f46f473000ac3629250fda Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/asus/p5gc-mx/acpi/mainboard.asl 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/40203/2
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40203?usp=email )
Change subject: mb/asus/p5gc-mx: Remove ACPI generic sleep button SLPB ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.